feat(db, webserver): Implement GitHubRepositoryProvider connect flow #1749

boxbeam · 2024-04-01T19:56:50Z

Relates to TAB-479

codecov · 2024-04-01T20:03:44Z

Codecov Report

Attention: Patch coverage is 0% with 249 lines in your changes are missing coverage. Please review.

Project coverage is 53.11%. Comparing base (f628f5c) to head (7d69008).

Files	Patch %	Lines
ee/tabby-webserver/src/integrations/github.rs	0.00%	99 Missing ⚠️
ee/tabby-db/src/github_repository_provider.rs	0.00%	76 Missing ⚠️
...ebserver/src/service/github_repository_provider.rs	0.00%	38 Missing ⚠️
...webserver/src/schema/github_repository_provider.rs	0.00%	10 Missing ⚠️
ee/tabby-webserver/src/service/mod.rs	0.00%	8 Missing ⚠️
ee/tabby-webserver/src/schema/mod.rs	0.00%	7 Missing ⚠️
ee/tabby-webserver/src/service/dao.rs	0.00%	7 Missing ⚠️
ee/tabby-webserver/src/handler.rs	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1749      +/-   ##
==========================================
- Coverage   54.38%   53.11%   -1.28%     
==========================================
  Files         117      121       +4     
  Lines       10227    10476     +249     
==========================================
+ Hits         5562     5564       +2     
- Misses       4665     4912     +247

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ee/tabby-db/migrations/0022_github-provider.up.sql

ee/tabby-db/src/github_provider.rs

ee/tabby-db/src/github_repository_provider.rs

Cargo.lock

ee/tabby-db/migrations/0022_github-provider.up.sql

ee/tabby-db/src/github_repository_provider.rs

ee/tabby-db/migrations/0022_github-provider.up.sql

ee/tabby-db/src/github_repository_provider.rs

ee/tabby-db/migrations/0022_github-provider.up.sql

wsxiaoys · 2024-04-09T14:55:28Z

ee/tabby-db/migrations/0022_github-provider.down.sql

@@ -0,0 +1,2 @@
+DROP TABLE github_repository_provider;
+DROP TABLE github_provided_repositories;


remove? BTW - can this type of error captured in unit test?

Already removed, and I'm not sure - we could have a CI tool which runs cargo sqlx db reset --source ee/tabby-db/migrations and then tries to de-migrate with cargo sqlx migrate revert, which should error if the down migration is invalid. I don't think a unit test could catch it, though.

ee/tabby-db/src/github_repository_provider.rs

ee/tabby-webserver/src/handler.rs

ee/tabby-webserver/src/schema/github_repository_provider.rs

ee/tabby-webserver/src/repositories/oauth.rs

ee/tabby-webserver/src/handler.rs

ee/tabby-webserver/src/integrations/github.rs

wsxiaoys

Otherwise LG!

ee/tabby-webserver/src/integrations/github.rs

wsxiaoys · 2024-04-09T17:35:54Z

ee/tabby-webserver/src/schema/mod.rs

@@ -226,6 +230,30 @@ impl Query {
        .await
    }



still need api for C/U/D? but it's fine to do it in a follow up PR

wsxiaoys · 2024-04-09T17:39:48Z

ee/tabby-webserver/src/integrations/github.rs

+
+fn get_authorize_url(client_id: &str, redirect_uri: &str, id: &ID) -> Result<Url> {


Suggested change

fn get_authorize_url(client_id: &str, redirect_uri: &str, id: &ID) -> Result<Url> {

// FIXME(boxbeam): refactoring the logic using `/oauth/github.rs`

fn get_authorize_url(client_id: &str, redirect_uri: &str, id: &ID) -> Result<Url> {

wsxiaoys · 2024-04-09T17:40:12Z

ee/tabby-webserver/src/integrations/github.rs

+
+async fn exchange_access_token(


Suggested change

async fn exchange_access_token(

// FIXME(boxbeam): refactoring the logic using `/oauth/github.rs`

async fn exchange_access_token(

boxbeam requested a review from wsxiaoys April 1, 2024 19:56

wsxiaoys requested changes Apr 2, 2024

View reviewed changes

wsxiaoys marked this pull request as draft April 2, 2024 00:44

boxbeam marked this pull request as ready for review April 2, 2024 18:12

wsxiaoys requested changes Apr 3, 2024

View reviewed changes

ee/tabby-db/src/github_repository_provider.rs Outdated Show resolved Hide resolved

ee/tabby-db/src/github_repository_provider.rs Outdated Show resolved Hide resolved

Cargo.lock Outdated Show resolved Hide resolved

wsxiaoys marked this pull request as draft April 3, 2024 00:47

boxbeam marked this pull request as ready for review April 3, 2024 18:20

wsxiaoys reviewed Apr 4, 2024

View reviewed changes

ee/tabby-db/migrations/0022_github-provider.up.sql Outdated Show resolved Hide resolved

wsxiaoys marked this pull request as draft April 4, 2024 01:43

boxbeam marked this pull request as ready for review April 4, 2024 17:36

wsxiaoys reviewed Apr 5, 2024

View reviewed changes

ee/tabby-db/migrations/0022_github-provider.up.sql Outdated Show resolved Hide resolved

wsxiaoys reviewed Apr 5, 2024

View reviewed changes

ee/tabby-db/migrations/0022_github-provider.up.sql Outdated Show resolved Hide resolved

wsxiaoys reviewed Apr 5, 2024

View reviewed changes

ee/tabby-db/src/github_repository_provider.rs Outdated Show resolved Hide resolved

wsxiaoys reviewed Apr 5, 2024

View reviewed changes

ee/tabby-db/src/github_repository_provider.rs Outdated Show resolved Hide resolved

wsxiaoys reviewed Apr 5, 2024

View reviewed changes

ee/tabby-db/migrations/0022_github-provider.up.sql Outdated Show resolved Hide resolved

wsxiaoys reviewed Apr 5, 2024

View reviewed changes

ee/tabby-db/src/github_repository_provider.rs Outdated Show resolved Hide resolved

wsxiaoys reviewed Apr 5, 2024

View reviewed changes

ee/tabby-db/src/github_repository_provider.rs Outdated Show resolved Hide resolved

wsxiaoys marked this pull request as draft April 5, 2024 05:31

boxbeam marked this pull request as ready for review April 5, 2024 21:27

wsxiaoys reviewed Apr 8, 2024

View reviewed changes

ee/tabby-db/migrations/0022_github-provider.up.sql Outdated Show resolved Hide resolved

wsxiaoys reviewed Apr 8, 2024

View reviewed changes

ee/tabby-db/migrations/0022_github-provider.up.sql Show resolved Hide resolved

boxbeam changed the title ~~feat(db): Create github provider table and DAO~~ feat(db): Implement GitHub Provider OAuth Flow Apr 9, 2024

boxbeam and others added 7 commits April 9, 2024 10:46

feat(db): Create github provider table and DAO

798ace9

[autofix.ci] apply automated fixes

db96a60

Apply suggestions

5638fbf

Apply suggestions, add DAO for github repositories

2aa6ddc

Add list query

61769ca

Apply suggestion

9e7a735

Apply suggestions

e2c8454

boxbeam added 2 commits April 9, 2024 10:53

Implement github provider OAuth flow

9aaa81f

Resolve conflicts

0623d09

boxbeam force-pushed the github-provider-db branch from ac4ba59 to 0623d09 Compare April 9, 2024 14:55

Fixup

83a31e4

wsxiaoys requested changes Apr 9, 2024

View reviewed changes

wsxiaoys marked this pull request as draft April 9, 2024 15:02

wsxiaoys reviewed Apr 9, 2024

View reviewed changes

ee/tabby-webserver/src/repositories/oauth.rs Outdated Show resolved Hide resolved

Apply suggestions, add GraphQL endpoints

86d2973

boxbeam force-pushed the github-provider-db branch from 284eb72 to 86d2973 Compare April 9, 2024 15:51

boxbeam marked this pull request as ready for review April 9, 2024 15:51

wsxiaoys changed the title ~~feat(db): Implement GitHub Provider OAuth Flow~~ feat(db): Implement GitHubRepositoryProvider integration flow Apr 9, 2024

wsxiaoys changed the title ~~feat(db): Implement GitHubRepositoryProvider integration flow~~ feat(db): Implement GitHubRepositoryProvider connect flow Apr 9, 2024

wsxiaoys reviewed Apr 9, 2024

View reviewed changes

ee/tabby-webserver/src/handler.rs Outdated Show resolved Hide resolved

Restructure routes

cc612aa

boxbeam force-pushed the github-provider-db branch from 0407350 to cc612aa Compare April 9, 2024 16:58

wsxiaoys reviewed Apr 9, 2024

View reviewed changes

ee/tabby-webserver/src/integrations/github.rs Outdated Show resolved Hide resolved

autofix-ci bot and others added 2 commits April 9, 2024 17:05

[autofix.ci] apply automated fixes

5387b8c

Use Url::parse_with_params to generate redirect url

9655a93

wsxiaoys reviewed Apr 9, 2024

View reviewed changes

ee/tabby-webserver/src/integrations/github.rs Outdated Show resolved Hide resolved

ee/tabby-webserver/src/integrations/github.rs Outdated Show resolved Hide resolved

boxbeam added 2 commits April 9, 2024 13:29

Apply suggestions

9810feb

Make redirect temporary

7d69008

wsxiaoys reviewed Apr 9, 2024

View reviewed changes

ee/tabby-webserver/src/integrations/github.rs Outdated Show resolved Hide resolved

wsxiaoys changed the title ~~feat(db): Implement GitHubRepositoryProvider connect flow~~ feat(db, webserver): Implement GitHubRepositoryProvider connect flow Apr 9, 2024

wsxiaoys reviewed Apr 9, 2024

View reviewed changes

wsxiaoys enabled auto-merge (squash) April 9, 2024 17:36

wsxiaoys approved these changes Apr 9, 2024

View reviewed changes

wsxiaoys reviewed Apr 9, 2024

View reviewed changes

wsxiaoys merged commit ed25f4a into main Apr 9, 2024
6 of 8 checks passed

wsxiaoys deleted the github-provider-db branch April 9, 2024 17:40

wsxiaoys reviewed Apr 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(db, webserver): Implement GitHubRepositoryProvider connect flow #1749

feat(db, webserver): Implement GitHubRepositoryProvider connect flow #1749

boxbeam commented Apr 1, 2024

codecov bot commented Apr 1, 2024 •

edited

Loading

wsxiaoys Apr 9, 2024

boxbeam Apr 9, 2024 •

edited

Loading

wsxiaoys left a comment

wsxiaoys Apr 9, 2024

wsxiaoys Apr 9, 2024

wsxiaoys Apr 9, 2024

		@@ -0,0 +1,2 @@
		DROP TABLE github_repository_provider;
		DROP TABLE github_provided_repositories;


		fn get_authorize_url(client_id: &str, redirect_uri: &str, id: &ID) -> Result<Url> {

feat(db, webserver): Implement GitHubRepositoryProvider connect flow #1749

feat(db, webserver): Implement GitHubRepositoryProvider connect flow #1749

Conversation

boxbeam commented Apr 1, 2024

codecov bot commented Apr 1, 2024 • edited Loading

Codecov Report

wsxiaoys Apr 9, 2024

Choose a reason for hiding this comment

boxbeam Apr 9, 2024 • edited Loading

Choose a reason for hiding this comment

wsxiaoys left a comment

Choose a reason for hiding this comment

wsxiaoys Apr 9, 2024

Choose a reason for hiding this comment

wsxiaoys Apr 9, 2024

Choose a reason for hiding this comment

wsxiaoys Apr 9, 2024

Choose a reason for hiding this comment

codecov bot commented Apr 1, 2024 •

edited

Loading

boxbeam Apr 9, 2024 •

edited

Loading